[18.0][MIG] edi_purchase_edifact_oca: Migration to 18.0#2
[18.0][MIG] edi_purchase_edifact_oca: Migration to 18.0#2
Conversation
P-H-Phuc
force-pushed
the
18.0-mig-edi_purchase_edifact_oca
branch
2 times, most recently
from
37c8988 to
81d1807
Compare
P-H-Phuc
force-pushed
the
18.0-mig-edi_purchase_edifact_oca
branch
3 times, most recently
from
7ba81e0 to
c2edcc9
Compare
P-H-Phuc
force-pushed
the
18.0-mig-edi_purchase_edifact_oca
branch
from
c2edcc9 to
06f11f0
Compare
thienvh332
left a comment
thienvh332
left a comment
There was a problem hiding this comment.
Where’s the module’s development history? Did you hide it somewhere? 😆
| for move in picking.move_lines: | ||
| move.quantity_done = move.product_uom_qty | ||
| self._update_qty_done_package(picking.move_lines) | ||
| picking = self.env["stock.picking"].browse(picking.id) |
There was a problem hiding this comment.
For what?
| picking = self.env["stock.picking"].browse(picking.id) |
There was a problem hiding this comment.
Migration to 18.0 from edi repo , how to include histories in edi-framework repo?
There was a problem hiding this comment.
picking = self.env["stock.picking"].browse(picking.id) I added it to debug and forgot to remove it
| ) | ||
| self.assertEqual(sum_quantity_done, 2.0) | ||
| sum_quantity_done = sum(self.purchase.order_line.mapped("move_ids.quantity")) | ||
| self.assertEqual(sum_quantity_done, 14.0) |
There was a problem hiding this comment.
If quantity_done is 14, it no longer matches the intended meaning of this test case. This is a consequence of changing setUp to setUpClass
| from odoo.addons.edi_oca.tests.common import EDIBackendTestMixin | ||
|
|
||
|
|
||
| @tagged("at_install", "-post_install") |
There was a problem hiding this comment.
This tag is the default one, isn’t it? What’s the difference?
| self.product_1 = self.env.ref("product.product_product_1") | ||
| self.product_1.default_code = "FURN_66668" | ||
| self.product_1.type = "product" | ||
| self.product_1.type = "consu" |
There was a problem hiding this comment.
Why is this in a [DON'T MERGE] commit? It should be moved to a [MIG] commit to avoid losing it during the merge.
| self.product_3 = self.env.ref("product.product_product_5") | ||
| self.product_3.default_code = "FURN_667777" | ||
| self.product_3.type = "product" | ||
| self.product_3.type = "consu" |
| name="order_file" | ||
| filename="order_filename" | ||
| attrs="{'readonly': [('import_type', '=', False)]}" | ||
| readonly="not import_type" |
| "name": "EDI PURCHASE EDIFACT OCA", | ||
| "summary": "Create and send EDIFACT order files", | ||
| "version": "18.0.1.0.0", | ||
| "version": "18.0.1.0.1", |
|
Replace by PR#4 |
2 participants
UN/EDIFACT
United Nations rules for Electronic Data Interchange for Administration,
Commerce and Transport
This module will support exporting and confirming orders in EDIFACT
format.
https://www.stedi.com/edi/edifact/D01B/messages/ORDERS
https://www.stedi.com/edi/edifact/D96A/messages/ORDERS
https://www.stedi.com/edi/edifact/D01B/messages/DESADV
https://www.stedi.com/edi/edifact/D96A/messages/DESADV