Fix frame-stats crash from unregistered lightGridPublish stage - #1
Open
Overhatch wants to merge 1 commit into
Open
Fix frame-stats crash from unregistered lightGridPublish stage#1Overhatch wants to merge 1 commit into
Overhatch wants to merge 1 commit into
Conversation
RtTerrain.stream times a terrain.lightGridPublish stage, but the name was never added to Profile's pre-declared array. Profile.indexOf throws IllegalArgumentException on an unknown name rather than ignoring it, so once frame-stats.enabled is set, the first light-grid publish throws on the render thread and drops RT back to vanilla wholesale. With frame stats off, count/stage short-circuit before the lookup, which is why this never surfaced. Audited every stage/endStage/count literal in the repo against the pre-declared arrays; this was the only omission. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RtTerrain.stream times a terrain.lightGridPublish stage, but the name was never
added to Profile's pre-declared array. Profile.indexOf throws
IllegalArgumentException on an unknown name rather than ignoring it, so once
frame-stats.enabled is set, the first light-grid publish throws on the render
thread and drops RT back to vanilla wholesale. With frame stats off, count/stage
short-circuit before the lookup, which is why this never surfaced.
Audited every stage/endStage/count literal in the repo against the pre-declared
arrays; this was the only omission.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com