Update to Laravel 6.x and PHP 7.2/7.3 #16
+1,957
−978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This health-check library depends on the
phpsafari/typed-collections
(https://github.com/OveD-php/typed-collections) library. I have updated both libraries to support Laravel 6.x and I am submitting PR for both libraries.Both PRs should be tagged/released at the same time, since this PR expect the
phpsafari/typed-collections
library namespace to change from "Phpsafari" to "PhpSafari".Both of my PRs drop support for Laravel 5.x due to dependency incompatibilities. My suggestion is to align the versioning of both of these Laravel libraries with Laravel versioning so that the existing versions (0.0.7 and 2.0.2) remain available as-is (or as 5.0.0?) to Laravel 5.x users and the new versions become available as 6.0.0 for Laravel 6.x users.
This library PR is currently forced to use my patched 6.0.0 version of
phpsafari/typed-collections
. After you upgrade thephpsafari/typed-collections
library to Laravel 6.x, be sure to remove the "repositories" section fromcomposer.json
in this library.Here is my PR for
phpsafari/typed-collections
with Laravel 6.x upgrades: OveD-php/typed-collections#3If you would like to test my updates with Laravel 6.x before accepting this PR and before publishing updated library versions, you can follow these steps:
composer.json
file:repositories
entries above.The 2-step method above is untested, but very similar to the method I am successfully using to import the custom versions of the libraries from my dev- branches into Laravel 6.
If you do not move to 6.0.0 versioning after using the method above, you will need to uninstall each package (e.g.
composer remove
), remove the customrepositories
entries from yourcomposer.json
, then reinstall each package (e.g.composer require
).