fix: adopt scene-aware UIWindow lookup for UIScene lifecycle - #9
Merged
Merged
Conversation
OS-ruimoreiramendes
changed the title
OS-ruimoreiramendes
marked this pull request as ready for review
July 30, 2026 10:39
OS-ruimoreiramendes
requested review from
ItsChaceD,
OS-pedrogustavobilro,
alexgerardojacinto,
andredestro,
capacitor-bot,
markemer and
theproducer
and removed request for
a team
July 30, 2026 10:39
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio. Pull Request Developer GuidanceQuestions? See the Wiz FAQ. Please contact the Security Office if you encounter issues with Wiz pull request scanning. |
alexgerardojacinto
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the deprecated
UIApplication.shared.keyWindow/[[UIApplication sharedApplication] keyWindow]usages to a scene-aware pattern that iteratesconnectedScenesand picks the key window from the activeUIWindowScene.The same pattern is in production in OSBarcodeLib-iOS and was recently applied to ion-ios-camera in ionic-team/ion-ios-camera#18.
To test this PR, you can use the latest build in ODC and O11, just to make sure that push notifications, dialogs, and in-app messages work correctly (yeah this is one of those that's hard to test 🥲)
Ref: https://outsystemsrd.atlassian.net/browse/RMET-5364