You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PyPI requires that all dist_require packages are publicly accessible using pip install <pkg>.
Because of this, URL commit/branch references are not permitted.
The package distribution is blocked by the following PR (so new official versions are published) until Mapgie can be pushed as well:
Big downside, INI is not backward compatible.
Because magpie is already taken on PyPI, and that the INI paste deploy loads using the same distribution name, all existing INI file references will have to change their reference to pavics-magpie.
ToDo
If we move on with this change, following must be done:
update requirements by URL references with pinned versions directly referring to pypi packages.
update all stack/instances that use an override Magpie INI config
add important changelog warning
major version update
add PYPI_API_TOKEN secret to repo to allow upload of tagged version by CI
Merging #518 (cf27f19) into master (27e060a) will increase coverage by 0.00%.
The diff coverage is 70.00%.
❗ Current head cf27f19 differs from pull request most recent head c7c23eb. Consider uploading reports for the commit c7c23eb to get more accurate results
@dbyrns Because there was a discussion about that recently, I gave a try to publish Magpie to PyPI. I found the issues listed in the PR description. Some of them make me feel it is not worth doing the change because it introduces a breaking change on existing platforms (mounted INI file in dockers).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciSomething related to code tests, deployment and packagingenhancementImprovements in term of performance or behaviourtestsTest execution or additional use cases
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocking Issues
PyPI requires that all
dist_requirepackages are publicly accessible usingpip install <pkg>.Because of this, URL commit/branch references are not permitted.
The package distribution is blocked by the following PR (so new official versions are published) until Mapgie can be pushed as well:
Breaking Change
Big downside, INI is not backward compatible.
Because
magpieis already taken on PyPI, and that the INI paste deploy loads using the same distribution name, all existing INI file references will have to change their reference topavics-magpie.ToDo
If we move on with this change, following must be done:
PYPI_API_TOKENsecret to repo to allow upload of tagged version by CI