Skip to content

fix(client): ignore stale SQL parser results #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HandSonic wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(client): ignore stale SQL parser results #2847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d9989f
fix(client): ignore stale SQL parser results
HandSonic Aug 31, 2026
076f9dc
Merge upstream main into fix/sql-parser-latest-request
HandSonic Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions chat2db-community-client/src/components/SQLEditor/core/completionProviderManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ class CompletionProviderManager {

public onParserChange = (sqlStatementList: SqlStatement[], curStatement?: SqlStatement) => {
this.sqlStatementList = sqlStatementList;
this.originColumnList = [];
if (curStatement) {
const { tableColumns } = curStatement;
const columns = (tableColumns || []).reduce((acc: ISimpleColumnVO[], cur) => {
Expand All @@ -254,10 +255,7 @@ class CompletionProviderManager {
return;
}

setTimeout(() => {
// this.registerParserColumnProvider(columns);
this.originColumnList = columns ?? [];
}, 1000);
this.originColumnList = columns;
}
};

Expand Down
1 change: 1 addition & 0 deletions chat2db-community-client/src/components/SQLEditor/core/sqlCompletionContext.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import assert from 'node:assert/strict';
import { getSqlCompletionContextId } from './sqlCompletionContext';
import './sqlParserRequestCoordinator.test';

assert.equal(
getSqlCompletionContextId({ consoleId: 42, workspaceTabId: 99 }),
Expand Down
40 changes: 40 additions & 0 deletions chat2db-community-client/src/components/SQLEditor/core/sqlExecutionTargetSnapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
export interface SqlExecutionPosition {
lineNumber: number;
column: number;
}

export interface SqlExecutionTargetSnapshot {
selectedSql: string;
cursorPosition: SqlExecutionPosition | null;
}

export interface ResolvedSqlExecutionTarget {
sql: string;
single: boolean;
}

export function createSqlExecutionTargetSnapshot(
selectedSql: string | null | undefined,
cursorPosition: SqlExecutionPosition | null | undefined,
): SqlExecutionTargetSnapshot {
return {
selectedSql: selectedSql || '',
cursorPosition: cursorPosition
? {
lineNumber: cursorPosition.lineNumber,
column: cursorPosition.column,
}
: null,
};
}

export function resolveSqlExecutionTarget(
snapshot: SqlExecutionTargetSnapshot,
getCursorSql: (position: SqlExecutionPosition) => string,
): ResolvedSqlExecutionTarget {
const sql = snapshot.selectedSql || (snapshot.cursorPosition ? getCursorSql(snapshot.cursorPosition) : '');
return {
sql,
single: !snapshot.selectedSql,
};
}
Loading
Loading