Repository navigation
Conversation
HandSonic
force-pushed
the
fix/desktop-ai-chat-error-callback
branch
2 times, most recently
from
September 3, 2026 08:35
3941455 to
b2bf399
Compare
HandSonic
force-pushed
the
fix/desktop-ai-chat-error-callback
branch
from
September 3, 2026 21:08
b2bf399 to
7aa7ea3
Compare
Align existing OtterMind/Chat2DB PR OtterMind#2821, retaining its focused behavior and current Community contracts.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - no matching issue was found.
Summary
Desktop AI SSE startup failures were rejected by the controller bridge without being delivered to the request-specific stream listener, leaving the consumer waiting indefinitely. Synchronous bridge callbacks could also fire before listener registration, while ordinary acknowledgement payloads could be mistaken for failures. This change normalizes controller/native failures into stream error events, defers synchronous dispatch until listener registration, settles missing or throwing bridges, and preserves normal acknowledgements.
The final manifest amendment keeps the expanded
test:sse-requestcommand but removes its redundant insertion into the shared prebuild chain. Community CI already invokes that named test directly, and the amendment avoids a merge conflict with the database-selector PR.Affected surfaces
Verification
yarn test:sse-request: passed ownership, transport, and production adapter contracts.git diff --check origin/main...HEAD: passed.2828cf80e: zero conflict markers; both selector and SSE test scripts are retained.7aa7ea315a32fefe2b8a6039abf5cb108ffe67a9: Frontend, Backend, JavaScript CodeQL, and Java CodeQL all passed.Risk and compatibility
Reviewer map
service/sse/requestFailure.ts, thenservice/sse/index.tsxand the adapter tests.2828cf80e.7aa7ea315a32fefe2b8a6039abf5cb108ffe67a9; no migration is required.Contributor declaration
AI assistance: OpenAI Codex assisted with diagnosis, implementation, automated tests, verification, conflict analysis, and adversarial review.
Latest-main revalidation (2026-09-04)