Repository navigation
fix(task): cancel registered statements once - #2811
Merged
openai0229 merged 2 commits intoSep 14, 2026
Merged
Conversation
HandSonic
force-pushed
the
fix/task-statement-cancel-once
branch
from
September 3, 2026 18:47
5441ff5 to
4a27cca
Compare
Contributor
Author
|
Exhaustive cross-PR integration update: combined this PR with #2802 in an isolated tree by preserving both cancellation-executor ownership and retryable input cleanup in RunningTask. The resulting full 9-module reactor passed: tools 68, domain-api 27, SPI 142, domain-core 256, storage 64, web 95 (1 environment skip), with 0 failures/errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - no matching issue was found.
Summary
When cancellation raced with JDBC statement registration, both requestCancellation and registerCancelable could schedule cancellation for the same resource. A previously retained synchronous compensation also risked blocking the task thread in a driver cancel call. This change linearizes token/resource publication under one lifecycle lock, claims one cancellation snapshot, and performs Future.cancel and driver cancellation outside the lock.
Affected surfaces
Verification
Risk and compatibility
Reviewer map
Contributor declaration
AI assistance: OpenAI Codex assisted with diagnosis, implementation, automated tests, verification, and adversarial review.