Repository navigation
Conversation
|
Blocking: this replaces the PostgreSQL parser with the MySQL grammar and visitors, not a BigQuery grammar. The test explicitly expects valid BigQuery |
openai0229
left a comment
There was a problem hiding this comment.
Requesting changes based on the blocking maintainer review comment above. Please address that comment, link the required standalone Bug issue(s), and update the branch against current main before requesting re-review.
d128e07 to
ba5be5f
Compare
|
Addressed the blocking review: the branch is rebased onto current |
ba5be5f to
091d81d
Compare
|
The first refreshed backend run exposed one stale grammar-coverage test left by the rejected MySQL-parser iteration. I restored that test to the current |
|
@openai0229 The requested changes are now addressed and the refreshed CI is fully green, including backend tests and Java/JavaScript CodeQL. Please re-review when available. |
091d81d to
0c083d8
Compare
|
@openai0229 Rebase complete at |
openai0229
left a comment
There was a problem hiding this comment.
The earlier parser-design blocker is addressed: the current head keeps PostgreSQL-backed analysis and overrides only BigQuery script splitting, with native syntax coverage. One stale dependency from the rejected MySQL-parser iteration still blocks merge, though: line 23 depends on , while now extends again.\n\nPlease restore the direct dependency and rebase this old branch onto current , then rerun the BigQuery module tests and backend package. The reactor happens to compile today through transitive reactor dependencies, but the module POM no longer declares the class it actually uses.
Superseded by a corrected review because shell quoting corrupted the submitted text.
openai0229
left a comment
There was a problem hiding this comment.
The earlier parser-design blocker is addressed: the current head keeps PostgreSQL-backed analysis and overrides only BigQuery script splitting, with native syntax coverage. One stale dependency from the rejected MySQL-parser iteration still blocks merge, though: chat2db-community-bigquery/pom.xml line 23 depends on chat2db-community-mysql, while BigQueryParser now extends PgsqlSqlParser again.
Please restore the direct chat2db-community-postgresql dependency and rebase this old branch onto current main, then rerun the BigQuery module tests and backend package. The reactor happens to compile today through transitive reactor dependencies, but the module POM no longer declares the class it actually uses.
…dialect on backtick-aware grammar (code review follow-up)
…E/DECLARE/EXPORT/LOAD) (codex review)
0c083d8 to
1fbd82f
Compare
Align existing OtterMind/Chat2DB PR OtterMind#2306 while preserving its focused fix.
Problem
BigQuery reused the PostgreSQL parser for script splitting. PostgreSQL lexical rules do not understand BigQuery backtick identifiers, triple-quoted strings, or procedural blocks, so valid scripts could be split at semicolons that belong inside a single statement.
Replacing the parser with a borrowed MySQL grammar would also be incorrect because it rejects native BigQuery scripting syntax.
Fix
BEGIN/IF/CASE/LOOP/WHILE/FOR/REPEATblocks, and labeled blocks.BEGIN TRANSACTIONas a top-level statement.Verification
BigQueryParserTest: 26 focused splitter tests).git diff --checkpassed.Fixes #2556