Skip to content

Simplify yield delegation process. #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

clement-ux
Copy link
Collaborator

Description

After multiple months of experience, managing delegateYield() and undelegateYield() through governance has turned out to be a pain point. This PR aims to reduce that friction by allowing the strategist to call these two functions.
This does not reduce security, as the only potential impact of a rogue strategist would be causing a user to lose yield.

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

@clement-ux clement-ux self-assigned this Jun 24, 2025
@clement-ux clement-ux requested a review from sparrowDom as a code owner June 24, 2025 10:55
@clement-ux clement-ux added the contracts Works related to contracts label Jun 24, 2025
@clement-ux clement-ux added the OUSD OUSD releated things label Jun 24, 2025
Copy link

github-actions bot commented Jun 24, 2025

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 0d74f10

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.24%. Comparing base (bfea30c) to head (0d74f10).
Report is 3 commits behind head on clement/manage-EIP-7702-for-OUSD.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           clement/manage-EIP-7702-for-OUSD    #2544      +/-   ##
====================================================================
+ Coverage                             41.18%   41.24%   +0.05%     
====================================================================
  Files                                   106      106              
  Lines                                  4956     4961       +5     
  Branches                               1302     1304       +2     
====================================================================
+ Hits                                   2041     2046       +5     
  Misses                                 2913     2913              
  Partials                                  2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clement-ux clement-ux marked this pull request as draft June 24, 2025 11:03
@clement-ux clement-ux marked this pull request as ready for review June 26, 2025 06:54
@clement-ux clement-ux merged commit 433ff01 into clement/manage-EIP-7702-for-OUSD Jun 26, 2025
19 checks passed
@clement-ux clement-ux deleted the clement/simplify-yield-delegation-governance branch June 26, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Works related to contracts OUSD OUSD releated things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant