Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Sonic Staking #2335

Draft
wants to merge 297 commits into
base: master
Choose a base branch
from
Draft

WIP Sonic Staking #2335

wants to merge 297 commits into from

Conversation

naddison36
Copy link
Collaborator

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

sparrowDom and others added 30 commits May 10, 2024 10:56
* add rate limit to calling manually fix accounting

* fix comment
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 59.37500% with 65 lines in your changes missing coverage. Please review.

Project coverage is 53.15%. Comparing base (a559741) to head (a6feef5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...racts/strategies/sonic/SonicValidatorDelegator.sol 60.43% 36 Missing ⚠️
...ontracts/strategies/sonic/SonicStakingStrategy.sol 48.78% 21 Missing ⚠️
contracts/contracts/token/WOSonic.sol 27.27% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2335      +/-   ##
==========================================
+ Coverage   52.59%   53.15%   +0.55%     
==========================================
  Files          80       86       +6     
  Lines        4101     4280     +179     
  Branches     1079     1134      +55     
==========================================
+ Hits         2157     2275     +118     
- Misses       1941     2002      +61     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naddison36 naddison36 marked this pull request as draft January 8, 2025 08:45
@naddison36 naddison36 changed the title Sonic Staking WIP Sonic Staking Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants