Upgrade tests #2318
Open
Upgrade tests #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opted out already
…ngly be used to return true for yield delegation sources
* use safecasts for any downcasting * use safecast when downcasting from int256. Also fix tests * prettier * clean up implementation
sparrowDom
requested review from
DanielVF,
naddison36,
shahthepro and
clement-ux
as code owners
shahthepro
reviewed
Dec 2, 2024
| for (let i = 0; i < data.length; i++) { | ||
| const [account,,balanceBefore] = data[i].split(','); | ||
| const expectedBalance = BigNumber.from(balanceBefore); | ||
| const actualBalance = await upgradedTokenContract.balanceOf(account) |
There was a problem hiding this comment.
Would be better to do this in batches using Promise.all
There was a problem hiding this comment.
Agreed, I didn't do that in the end because all the storage slots are already cached and this function executes quite quickly
shahthepro
reviewed
Dec 2, 2024
This reverts commit dc854bc.
…nto sparrowDom/upgrade_tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only a pull request to perform the upgrade tests of token contract that check that all the token balances of OUSD, OETH and Super OETH remain the same after the contract upgrade. See
contracts/test/token/README.mdon how to execute the procedure.This PR should not be merged