[ResourceLib] Fully implement UICB support #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, normally it's written as a uint32_t and then 0xFFFFFFFF, the game's files have this as zero. Changing the type here fixes it, I think we're writing over the padding. I don't think anything should go wrong here...
|
It's still crashing sometimes. @OrfeasZ if you can take a look when you're available. I've probably messed something up somewhere. Hopefully what I've done can give you a better insight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit dodgy in parts (the code) because I was only 90% sure how the serialize works. It's definitely not a thing you could easily 1:1 from game structures since it's read differently and it's modified when being installed. The game calls it an array of "control types", this type being SAttributeInfo, and it loops through them to find pins and properties then registers them in its own arrays.
The code, and by extension the JSON format, could be slimmed by removing the enum <-> string conversion, but that reduces the readability of the output. An argument could be made that RT doesn't do that for RRIDs, but that's a different case entirely as it preserves the game's runtime format.
EDIT: Pending new build...