Fix officer face aspect ratio #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AetherUnbound
approved these changes
May 1, 2025
Collaborator
AetherUnbound
left a comment
AetherUnbound
left a comment
There was a problem hiding this comment.
THANK YOU for fixing this!!
github-project-automation
bot
moved this from 📋 Backlog
to ✅ Done
in Orca Collective Task Tracker
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fix officer face aspect ratio on the browse page.
The officer face thumbnail currently inherits the column width (
col-md-4 col-12) and has a set height of 300. This causes images that aren't this particular size to become warped.This change adds the
object-fit: coverCSS property to theofficer-faceclass, which preserves the thumbnail aspect ratio.https://developer.mozilla.org/en-US/docs/Web/CSS/object-fit
Notes for Deployment
None!
Screenshots (if appropriate)
Before:
After:
Testing instructions
Checks
I have rebased my changes on
mainjust lintpassesjust testpasses