Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a11y audit 0-6: focus order for the copy button on code example #2699

Merged
merged 13 commits into from
Oct 14, 2024
Merged

Fix a11y audit 0-6: focus order for the copy button on code example #2699

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0244404
Fix focus order for the copy button on code example only
louismaximepiton Aug 20, 2024
2d525ab
Merge branch 'main' into main-lmp-a11y-0-6-focus-order
hannahiss Sep 5, 2024
90d5976
Merge branch 'main' into main-lmp-a11y-0-6-focus-order
julien-deramond Oct 1, 2024
eb38546
Merge branch 'main' into main-lmp-a11y-0-6-focus-order
julien-deramond Oct 1, 2024
0d5504e
Merge branch 'main' into main-lmp-a11y-0-6-focus-order
julien-deramond Oct 2, 2024
a1732b9
Change focus order for every example.
louismaximepiton Oct 2, 2024
299da6f
Consistent approach and less ugly code imo
louismaximepiton Oct 2, 2024
b5a281c
Merge branch 'main' into main-lmp-a11y-0-6-focus-order
julien-deramond Oct 11, 2024
93e39d3
Add missing Boosted mods
julien-deramond Oct 11, 2024
bfdf300
Add missing Boosted mods
julien-deramond Oct 11, 2024
3fc4739
Add missing Boosted mods
julien-deramond Oct 11, 2024
324f6fa
Merge branch 'main' into main-lmp-a11y-0-6-focus-order
julien-deramond Oct 14, 2024
5591277
Merge branch 'main' into main-lmp-a11y-0-6-focus-order
julien-deramond Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions site/assets/js/partials/code-examples.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ export default () => {

// Boosted mod: removed unused svg height, width and fill="currentColor"
const btnHtml = [
'<div class="bd-code-snippet">',
' <div class="bd-clipboard">',
' <button type="button" class="btn-clipboard">',
'<div class="bd-code-snippet position-relative">',
' <div class="bd-clipboard position-absolute top-0 end-0">',
' <button type="button" class="btn-clipboard position-absolute end-0">',
vprothais marked this conversation as resolved.
Show resolved Hide resolved
' <svg class="bi" role="img" aria-label="Copy"><use xlink:href="#clipboard"/></svg>',
' </button>',
' </div>',
Expand All @@ -35,7 +35,7 @@ export default () => {
// Ignore examples made by shortcode
if (!element.closest('.bd-example-snippet')) {
element.insertAdjacentHTML('beforebegin', btnHtml)
element.previousElementSibling.append(element)
element.previousElementSibling.prepend(element)
}
})

Expand Down
Loading