fix: correctly handle value of initialPromise for fetchWhenDepsChange conditions in useLoadData
#28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
On initial load, when passing dependencies into
useLoadData
that are immediately ready (presumably because they were cached or were never asynchronous in nature), we proceed to try and immediately invoke fetchData, and therefore have initialPromise defined. If initialPromise is in fact a promise, we await it's resolution inside of loadData, and provide the result into the state.However, in the situation where we desire to re-invoke fetchData to account for updated dependencies (when fetchWhenDepsChange is true in the config), initialPromise is still defined, and bypasses any proceeding fetchData calls.
This PR introduces a fix to this scenario, where we unset initialPromise whenever we enter fetchWhenDepsChange flows.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...