Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle value of initialPromise for fetchWhenDepsChange conditions in useLoadData #28

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

NielsJPeschel
Copy link
Contributor

Proposed changes

On initial load, when passing dependencies into useLoadData that are immediately ready (presumably because they were cached or were never asynchronous in nature), we proceed to try and immediately invoke fetchData, and therefore have initialPromise defined. If initialPromise is in fact a promise, we await it's resolution inside of loadData, and provide the result into the state.

However, in the situation where we desire to re-invoke fetchData to account for updated dependencies (when fetchWhenDepsChange is true in the config), initialPromise is still defined, and bypasses any proceeding fetchData calls.

This PR introduces a fix to this scenario, where we unset initialPromise whenever we enter fetchWhenDepsChange flows.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@NielsJPeschel NielsJPeschel requested a review from nthurow April 1, 2024 15:43
@NielsJPeschel NielsJPeschel changed the title fix: correctly handle value for initialPromise for fetchWhenDepsChange conditions in useLoadData fix: correctly handle value of initialPromise for fetchWhenDepsChange conditions in useLoadData Apr 1, 2024
@nthurow nthurow merged commit e3ec0aa into main Apr 2, 2024
4 checks passed
@nthurow nthurow deleted the fetchWhenDepsChange-fix branch April 2, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants