Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable useServiceEffect to receive a Promisable service param #25

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

NielsJPeschel
Copy link
Contributor

Proposed changes

Enable useServiceEffect to receive a function that is promisable (Promise | T)

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@NielsJPeschel NielsJPeschel requested a review from nthurow March 25, 2024 13:16
@NielsJPeschel NielsJPeschel changed the title Enable useServiceEffect to receive a _Promisable_ service param Enable useServiceEffect to receive a Promisable service param Mar 25, 2024
@nthurow nthurow merged commit 57758ad into main Mar 25, 2024
4 checks passed
@nthurow nthurow deleted the useServiceEffect-promisable branch March 25, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants