Navlink merch store target fix #1848
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
operation_code
|
||||||||||||||||||||||||||||
| Project |
operation_code
|
| Branch Review |
pull/1848
|
| Run status |
|
| Run duration | 03m 35s |
| Commit |
|
| Committer | Franciscus Agnew |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
25
|
| View all changes introduced in this branch ↗︎ | |
|
looks like diff padding/margin between the items. also, it's missing the iconography used in other locations. i think |
|
@kylemh: Yes, I observed that as well. I wanted to confirm the implementation of the OutboundLink functionality as requested within the navigation before making any visual changes. I wasn't certain whether or not to include the icon and set it to false, thanks for the clarifications. I believe we got it all covered now! |
|
Ah. Functionally, it's perfect! |
|
Code Climate has analyzed commit 038398f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 82.6% (90% is the threshold). This pull request will bring the total coverage in the repository to 81.1% (0.0% change). View more on Code Climate. |
Description of changes
This PR fixes a minor routing issue with the Merch Store navigation link where an outside link opens in the current tab instead of a new tab as recommended and as it does in the “Get Involved” page.
Issue Resolved
Fixes #NA
Screenshots/GIFs
BEFORE:
Opens in the current browser tab
AFTER:
Opens in a new browser tab