Migrate Drawer, ErrorDisplay, and FeaturedJobItem components to typescript #1804
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
recondesigns
changed the title
| <div | ||
| className={classNames( | ||
| className, | ||
| 'hidden lg:block transition-all ease-in-out duration-1000 fixed top-0 bottom-0 overflow-hidden width-full z-[2]', |
There was a problem hiding this comment.
| 'hidden lg:block transition-all ease-in-out duration-1000 fixed top-0 bottom-0 overflow-hidden width-full z-[2]', | |
| 'hidden lg:block transition-all ease-in-out duration-1000 fixed top-0 bottom-0 overflow-hidden width-full z-[2]', |
same
There was a problem hiding this comment.
There doesn't appear to be a change in the suggestion. Am I missing a tiny detail?
There was a problem hiding this comment.
there are 2 spaces between bottom-0 and overflow-hidden. Perhaps you need to lower the contrast on your monitor?
There was a problem hiding this comment.
Ahhhh... I actually did see it, but didn't know what it was. This is merged, should I make that change in one of the other branches I am working?
|
Code Climate has analyzed commit cc8587d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 80.3%. View more on Code Climate. |
Passing run #4669 ↗︎
Details:
Review all test suite changes for PR #1804 ↗︎ |
|||||||||||||||
Description of changes
Migrated the following components to Typescript, removed prop-types, and added a props type:
DrawerErrorDisplayFeaturedJobItemMigrating components included all test and storybook files for each.
Issue Resolved
Fixes #NA
Screenshots/GIFs
All new
.tsxfiles