feat(app): use CSS Modules for RobotSettings Dashboard #18778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use CSS Modules for RobotSettings Dashboard close AUTH-
koji
requested review from
sfoster1,
smb2268,
ncdiehl11,
mjhuff,
jerader,
SyntaxColoring and
TamarZanzouri
jerader
reviewed
Jul 1, 2025
| <Icon | ||
| name="alert-circle" | ||
| className={styles.icon_large} | ||
| color="#171717" |
There was a problem hiding this comment.
you removed the color const since we won't be using those anymore?
jerader
reviewed
Jul 1, 2025
| @@ -134,8 +123,8 @@ export function RobotSettingsList(props: RobotSettingsListProps): JSX.Element { | |||
| hug={true} | |||
| /> | |||
| ) : null} | |||
| <Icon name="more" size="3rem" color={COLORS.black90} /> | |||
| </Flex> | |||
| <Icon name="more" className={styles.icon_large} color="#171717" /> | |||
jerader
reviewed
Jul 1, 2025
| <Icon name={iconName} className={styles.icon_large} color="#171717" /> | ||
| ) : null} | ||
| <div className={styles.text_content}> | ||
| <LegacyStyledText as="h4" className={styles.setting_name}> |
There was a problem hiding this comment.
still using legacy styled text here?
jerader
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use CSS Modules for RobotSettings Dashboard
close AUTH-
Overview
use CSS Modules for RobotSettings Dashboard
This worked with ODD mode, but I couldn't test this branch on a Flex since I got a robot server issue, and the app didn't start. I will try to run this branch on a Flex again.
close AUTH-2025
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
should be low