chore(shared-data): lock in command schema 13 for RS 8.5.0, bump other changes to 14.json

[ddcc4]

Overview

We just cut chore_release-8.5.0, which is a limited cherrypick release. We need to lock command schema 13.json to the version of the file that we're releasing in RS 8.5.0, and move all other changes to the new 14.json.

Note that this change is going into chore_release-pd-8.5.0. Again, our strategy is that changes should flow from chore_release-pd-8.5.0 -> edge.

Test Plan and Hands on Testing

Will rely on CI testing.

Risk assessment

Medium.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.46%. Comparing base (d43bf7f) to head (7a21bec).
Report is 14 commits behind head on chore_release-pd-8.5.0.

Additional details and impacted files

@@                   Coverage Diff                   @@
##           chore_release-pd-8.5.0   #18475   +/-   ##
=======================================================
  Coverage                   26.46%   26.46%           
=======================================================
  Files                        3255     3255           
  Lines                      277347   277347           
  Branches                    32231    32231           
=======================================================
  Hits                        73398    73398           
  Misses                     203920   203920           
  Partials                       29       29           

Flag	Coverage Δ
protocol-designer	19.39% <100.00%> (ø)
step-generation	4.60% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
shared-data/command/index.ts	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sfoster1]

I guess I assumed that schema 14 wouldn't exist in 8.5.0 at all, and that a PR like this would just be the 13.json changes, and there would be a second PR to edge alone that created 14.json. Our code and our expectations use "the schema file exists" as a token for "the schema version is supported". If this is how you want to do it though, let's get it done.

[ddcc4]

I guess I assumed that schema 14 wouldn't exist in 8.5.0 at all, and that a PR like this would just be the 13.json changes, and there would be a second PR to edge alone that created 14.json. Our code and our expectations use "the schema file exists" as a token for "the schema version is supported". If this is how you want to do it though, let's get it done.

Oh sorry @sfoster1, our branch names are VERY confusing :(

Note that this PR targets chore_release-PD-8.5.0. The upcoming PD release is going to be much newer that RS 8.5.0 -- it's basically edge without the 4th column.

So anything we want in the in the post-RS-8.5.0 releases should go into both chore_release-pd-8.5.0 and edge. By committing the change into chore_release-pd-8.5.0 first and then merging into edge, we save ourselves the trouble of committing to edge and then having to cherrypick back into chore_release-pd-8.5.0 (which would create duplicate commits in the git log).