Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(components, protocol-designer): menuList and MenuItem cleanup for helix #17257
base: edge
Are you sure you want to change the base?
refactor(components, protocol-designer): menuList and MenuItem cleanup for helix #17257
Changes from all commits
005f92c
a29a8c1
9feee26
5ea4660
06f2fdb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should avoid using calc for a prop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably we should avoid passing
undefined
by set the default value inMenuList
.Unchanged files with check annotations Beta
Check warning on line 62 in api-client/src/pipettes/types.ts
Check warning on line 62 in api-client/src/pipettes/types.ts
Check warning on line 69 in api-client/src/pipettes/types.ts
Check warning on line 69 in api-client/src/pipettes/types.ts
Check warning on line 77 in api-client/src/pipettes/types.ts
Check warning on line 77 in api-client/src/pipettes/types.ts
Check warning on line 81 in api-client/src/pipettes/types.ts
Check warning on line 81 in api-client/src/pipettes/types.ts
Check warning on line 90 in api-client/src/pipettes/types.ts
Check warning on line 90 in api-client/src/pipettes/types.ts
Check warning on line 14 in api-client/src/types.ts
Check warning on line 14 in api-client/src/types.ts
Check warning on line 360 in app-shell-odd/src/actions.ts
Check warning on line 360 in app-shell-odd/src/actions.ts
Check warning on line 368 in app-shell-odd/src/actions.ts
Check warning on line 368 in app-shell-odd/src/actions.ts
Check warning on line 376 in app-shell-odd/src/actions.ts
Check warning on line 376 in app-shell-odd/src/actions.ts
Check warning on line 384 in app-shell-odd/src/actions.ts
Check warning on line 384 in app-shell-odd/src/actions.ts