fix(api): Disable tip presence check on 8ch single and partial 2 thru 3 nozzle #16312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyBatten
requested review from
y3rsh,
Carlos-fernandez,
nusrat813,
andy-g-calderon and
rclarke0
SyntaxColoring
approved these changes
Sep 20, 2024
| NozzleConfigurationType.SINGLE, | ||
| NozzleConfigurationType.COLUMN, | ||
| ] | ||
| supported_partial_nozzle_minimum = 4 |
There was a problem hiding this comment.
Can you elaborate in the in-code comments about where 4 comes from?
| ): | ||
| # Tip presence sensing is not supported for single tip pick up on the 96ch Flex Pipette | ||
| # Tip presence sensing is not supported for single tip pick up on the 96ch Flex Pipette, nor with single and some partial layous of the 8ch Flex Pipette |
There was a problem hiding this comment.
Can you elaborate in the in-code comments about why these layouts aren't supported?
vegano1
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Looking good
I agree with @SyntaxColoring on adding comments explaining why we are doing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Covers RABR-623, RABR-624
Disable tip presence sensing on the 8ch Flex pipette for Single tip configuration and for Partial Column
Test Plan and Hands on Testing
Tested on Flex with 8ch pipette to confirm tip presence no used for 1-3 nozzle configurations.
Re-tested Flex 96ch to ensure tip presence sensing not used for single nozzle configuration.
Changelog
Expanded tip handle tip presence validation to screen for 8ch configurations.
Review requests
Does this offer sufficient coverage?
Risk assessment
Low - disables tip presence check exclusively on some new features to 8.0.0.