Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): don't lpd for each step in a mix #16310

Merged
merged 8 commits into from
Oct 1, 2024
Merged

fix(api): don't lpd for each step in a mix #16310

merged 8 commits into from
Oct 1, 2024

Conversation

ryanthecoder
Copy link
Contributor

@ryanthecoder ryanthecoder commented Sep 19, 2024

Overview

If an instrument is set to have Liquid Presence Detection on and their is a call to instrument.mix then the pipette will exit the liquid, do a LPD and then re-enter for each cycle. This change makes it so that it saves the state of the instrument, does LPD on the first aspirate and then turns LPD off. Once Mix is complete then LPD is toggled back to whatever state it was in before.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

Low: If an error somehow occurs during the mix cycle and the command is bypassed then the instrument may be left with LPD off.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.43%. Comparing base (f793e65) to head (7b3611a).
Report is 71 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #16310   +/-   ##
=======================================
  Coverage   92.43%   92.43%           
=======================================
  Files          77       77           
  Lines        1283     1283           
=======================================
  Hits         1186     1186           
  Misses         97       97           
Flag Coverage Δ
g-code-testing 92.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanthecoder ryanthecoder changed the base branch from chore_release-8.0.0 to edge September 23, 2024 15:20
@ryanthecoder ryanthecoder marked this pull request as ready for review September 23, 2024 15:20
@ryanthecoder ryanthecoder requested a review from a team as a code owner September 23, 2024 15:20
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that it's on edge we should target on next api version

api/src/opentrons/protocol_api/instrument_context.py Outdated Show resolved Hide resolved
api/src/opentrons/protocol_api/instrument_context.py Outdated Show resolved Hide resolved
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but add a test before merging please

@ryanthecoder ryanthecoder merged commit e799e9b into edge Oct 1, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants