-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): don't lpd for each step in a mix #16310
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #16310 +/- ##
=======================================
Coverage 92.43% 92.43%
=======================================
Files 77 77
Lines 1283 1283
=======================================
Hits 1186 1186
Misses 97 97
Flags with carried forward coverage won't be shown. Click here to find out more. |
1d14c27
to
da050f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that it's on edge we should target on next api version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but add a test before merging please
fd075f5
to
c0ac577
Compare
Overview
If an instrument is set to have Liquid Presence Detection on and their is a call to instrument.mix then the pipette will exit the liquid, do a LPD and then re-enter for each cycle. This change makes it so that it saves the state of the instrument, does LPD on the first aspirate and then turns LPD off. Once Mix is complete then LPD is toggled back to whatever state it was in before.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
Low: If an error somehow occurs during the mix cycle and the command is bypassed then the instrument may be left with LPD off.