feat(protocol engine): calculate volume and height for irregular well shapes #16299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously in
frustum_helpers
, we were only handling the cases where wells had either all circular or all rectangular cross sections. If neither of these is the case, let's iterate through all the cross-sections and find the volume using the volume-of-a-frustum formula.Review Requests
Pls help me make sure I input the formula correctly