fix(protocol-designer): fix 96-channel display issue in select pipettes #16287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify the button display condition to solve 96-channel button display issue close RQA-3203
jerader
reviewed
Sep 19, 2024
| } | ||
| }, [pipetteType, pipetteGen, pipetteVolume, selectedPip]) | ||
| }, [pipetteType, pipetteVolume, selectedPipetteName]) |
There was a problem hiding this comment.
pipetteGen is needed for an ot-2 pipette. Maybe we need to do something like:
Suggested change
| }, [pipetteType, pipetteVolume, selectedPipetteName]) | |
| if (pipetteType != null && pipetteVolume != null && (robotType === OT2_ROBOT_TYPE && pipetteGen != null)) { | |
| setValue( | |
| `pipettesByMount.${defaultMount}.pipetteName`, | |
| selectedPipetteName | |
| ) | |
| } | |
| }, [pipetteType, pipetteGen, pipetteVolume, selectedPipetteName]) |
jerader
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
modify the button display condition to solve 96-channel button display issue
change marginBottom to gridGap
after
96-Channel-button-issue.mov
close RQA-3203
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low