Power function #505
Open
Power function #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
==========================================
+ Coverage 95.02% 95.06% +0.03%
==========================================
Files 77 77
Lines 5309 5408 +99
==========================================
+ Hits 5045 5141 +96
- Misses 264 267 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brozorec
approved these changes
Nov 26, 2025
Collaborator
brozorec
left a comment
brozorec
left a comment
There was a problem hiding this comment.
great job with the re-org 🙌 just couple of nit picks and improving the coverage for checked_mul_div_floor
| /// `WAD_SCALE`. | ||
| pub fn checked_mul(self, e: &Env, rhs: Wad) -> Option<Wad> { | ||
| // Use fixed_mul_floor to handle phantom overflow transparently | ||
| let result = self.0.fixed_mul_floor(e, &rhs.0, &WAD_SCALE); |
Collaborator
There was a problem hiding this comment.
Shouldn't we use checked_fixed_mul_floor so that it returns None instead of panicking on overflow?
| } | ||
| } | ||
|
|
||
| /// Performs floor(x * y / z) |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// Performs ceil(x * y / z) |
| let zero = I256::from_i32(env, 0); | ||
| let r = x.mul(y); | ||
|
|
||
| if z.clone() == zero { |
Collaborator
There was a problem hiding this comment.
instead of cloning, wouldn't it be better to dereference z here and in the next fn?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #499
PR Checklist
Also restructures the math library