Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crypto): 256-bit security (256 capacity) for 64-bit poseidon instances #613

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

qalisander
Copy link
Member

@qalisander qalisander commented Mar 19, 2025

256-bit capacity (space unaffected by input) for sponge hash function is preferable nowadays

PR Checklist

  • Tests
  • Documentation
  • Changelog

Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit 9796ae8
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/67dab9d2465c340008fcd8d8

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.5%. Comparing base (65d5cfd) to head (9796ae8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Files with missing lines Coverage Δ
lib/crypto/src/poseidon2/instance/babybear.rs 100.0% <100.0%> (ø)
lib/crypto/src/poseidon2/instance/goldilocks.rs 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@bidzyyys
Copy link
Collaborator

@qalisander update CHANGELOG please

@qalisander
Copy link
Member Author

will do

@qalisander qalisander marked this pull request as ready for review March 19, 2025 12:46
@qalisander qalisander requested a review from 0xNeshi as a code owner March 19, 2025 12:46
@0xNeshi 0xNeshi merged commit f854ae6 into main Mar 21, 2025
25 checks passed
@0xNeshi 0xNeshi deleted the openzeppelin-crypto/set-256-bit-security-for-posseidon branch March 21, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants