Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reimplement erc165 for erc20 #591

Merged
merged 7 commits into from
Mar 6, 2025
Merged

feat: reimplement erc165 for erc20 #591

merged 7 commits into from
Mar 6, 2025

Conversation

0xNeshi
Copy link
Collaborator

@0xNeshi 0xNeshi commented Mar 5, 2025 •
edited
Loading

Reverts change introduced in #570

Towards #592

PR Checklist

  • Tests
  • Documentation
  • Changelog

@0xNeshi 0xNeshi self-assigned this Mar 5, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 5, 2025 •
edited
Loading

✅ Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit bd8a388
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/67c99c2021bf2c00089bbfeb

@codecov Codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.1%. Comparing base (2afef78) to head (bd8a388).
Report is 1 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
contracts/src/token/erc20/extensions/metadata.rs 62.0% <100.0%> (+35.4%) ⬆️
contracts/src/token/erc20/mod.rs 97.1% <100.0%> (+0.1%) ⬆️
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xNeshi 0xNeshi mentioned this pull request Mar 5, 2025
Merged
bidzyyys
bidzyyys approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Could you remove in this PR this CI warning?

Check warning on line 5 in examples/erc20-permit/tests/erc20permit.rs

use of deprecated enum `alloy_primitives::Parity`: see https://github.com/alloy-rs/core/pull/776

qalisander
qalisander approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@qalisander qalisander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xNeshi 0xNeshi merged commit 97fd57b into main Mar 6, 2025
15 of 16 checks passed
@0xNeshi 0xNeshi deleted the reimpl-erc165-for-erc20 branch March 6, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidzyyys bidzyyys bidzyyys approved these changes

@qalisander qalisander qalisander approved these changes

Assignees

@0xNeshi 0xNeshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xNeshi @bidzyyys @qalisander