feature: eliptic curves #589
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for contracts-stylus ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…elin-crypto/eliptic-curves
…liptic-curves # Conflicts: # fuzz/Cargo.lock
qalisander
force-pushed
the
openzeppelin-crypto/eliptic-curves
branch
from
ad18d44 to
112946f
Compare
|
merge simple test cases (coverage) |
|
fix clippy lints |
bidzyyys
reviewed
Mar 19, 2025
|
|
||
| #[inline] | ||
| fn add(self, other: Self) -> Self { | ||
| let mut result = self; |
There was a problem hiding this comment.
Why can't you use just self + &other?
| /// Elliptic curves can be represented via different "models" with varying | ||
| /// efficiency properties. | ||
| /// | ||
| /// `CurveConfig` bundles together the types that are common |
There was a problem hiding this comment.
Suggested change
| /// `CurveConfig` bundles together the types that are common | |
| /// [`CurveConfig`] bundles together the types that are common |
| /// efficiency properties. | ||
| /// | ||
| /// `CurveConfig` bundles together the types that are common | ||
| /// to all models of the given curve, namely the `BaseField` over which the |
There was a problem hiding this comment.
Suggested change
| /// to all models of the given curve, namely the `BaseField` over which the | |
| /// to all models of the given curve, namely the [`BaseField`] over which the |
| /// | ||
| /// `CurveConfig` bundles together the types that are common | ||
| /// to all models of the given curve, namely the `BaseField` over which the | ||
| /// curve is defined, and the `ScalarField` defined by the appropriate |
There was a problem hiding this comment.
Suggested change
| /// curve is defined, and the `ScalarField` defined by the appropriate | |
| /// curve is defined, and the [`ScalarField`] defined by the appropriate |
|
|
||
| /// Returns `true` if the cofactor is one. | ||
| fn cofactor_is_one() -> bool { | ||
| Self::COFACTOR[0] == 1 |
There was a problem hiding this comment.
Whag if Self::COFACTOR is an empty slice?
| } | ||
|
|
||
| // Invert `tmp`. | ||
| tmp = tmp.inverse().unwrap(); // Guaranteed to be nonzero. |
| } | ||
|
|
||
| impl<P: SWCurveConfig> Affine<P> { | ||
| /// Constructs a group element from x and y coordinates. |
There was a problem hiding this comment.
Suggested change
| /// Constructs a group element from x and y coordinates. | |
| /// Constructs a group element from `x` and `y` coordinates. |
| point | ||
| } | ||
|
|
||
| /// Constructs a group element from x and y coordinates. |
There was a problem hiding this comment.
Suggested change
| /// Constructs a group element from x and y coordinates. | |
| /// Constructs a group element from `x` and `y`coordinates. |
|
|
||
| /// Checks if `self` is a valid point on the curve. | ||
| pub fn is_on_curve(&self) -> bool { | ||
| if !self.infinity { |
There was a problem hiding this comment.
Clippy warning that makes sense.
| impl<P: SWCurveConfig> Eq for Projective<P> {} | ||
| impl<P: SWCurveConfig> PartialEq for Projective<P> { | ||
| fn eq(&self, other: &Self) -> bool { | ||
| if self.is_zero() { |
There was a problem hiding this comment.
Looks like XOR operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #343
PR Checklist