Skip to content

Conversation

@MCarlomagno
Copy link
Member

@MCarlomagno MCarlomagno commented Dec 4, 2025

  • First implementation of miden-multisig-client supporting:
    • transaction proposals
      • creation
      • signing
      • execution
      • psm coordination
      • offline coordination (import/export into files)
    • transaction types
      • create_p2id_note
      • consume_notes
      • add_signer
      • remove_signer
      • switch_psm
  • Update and simplify demo using miden-multisig-client

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 21.64839% with 2215 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.60%. Comparing base (7bc139d) to head (a3a33b7).

❌ Your patch status has failed because the patch coverage (21.64%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #72       +/-   ##
===========================================
- Coverage   74.34%   55.60%   -18.74%     
===========================================
  Files          43       66       +23     
  Lines        5125     7952     +2827     
===========================================
+ Hits         3810     4422      +612     
- Misses       1315     3530     +2215     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bc139d...a3a33b7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MCarlomagno MCarlomagno merged commit b103f36 into main Dec 5, 2025
12 checks passed
@MCarlomagno MCarlomagno deleted the multisig-client branch December 5, 2025 20:05
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants