Cache memory pointer in areValidSignaturesNow

[ernestognw]

Fixes #????

PR Checklist

• Tests
• Documentation
• Changeset entry (run npx changeset add)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 87687a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[Amxx]

I'm not sure I understand this change.

We want to save/reset the FMP when memory is allocated. In the case of areValidSignaturesNow, no memory is allocated (directly). Line 146 is a memory pointer copy on slack. I guess that includes an mload an a add, but no mstore. Same for the signatures[i] on line 149.

There might be memory allocation in isValidSignatureNow for the encoded call (line 117) ... but I'd say we should handle memory there and not in areValidSignatureNow

[ernestognw]

Hey @Amxx, yes you're right. I opened the PR to see what would be the actual changes in the gas estimation but I didn't see much change.

I'd say we should handle memory there and not in areValidSignatureNow

That makes sense but I'm still not sure if it's worth to do it inside of isValidSignatureNow either. If the signature is not too long, the computation of caching the fmp and restoring it may undermine the savings.