-
Notifications
You must be signed in to change notification settings - Fork 12k
Add Blockhash library following EIP-2935 #5642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 1e95107 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Tests are missing, perhaps there's a way to enable 2935 in either Foundry or Hardhat but requires some research before continue |
Yeah I'm also trying to test in Foundry and it doesn't really work 😕 |
@@ -1,6 +1,6 @@ | |||
[profile.default] | |||
solc_version = '0.8.24' | |||
evm_version = 'cancun' | |||
evm_version = 'prague' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this is unnecessary since we're vm.etch
'ing the bytecode anyway. I couldn't find anythign about EIP-2935 in the Foundry docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a Blockhash library as per EIP-2935, extending access to historical block hashes beyond the standard 256-block limit.
- Updates the EVM version in foundry.toml from 'cancun' to 'prague' to support new EIP features.
- Adds a changeset entry detailing the Blockhash library feature.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
foundry.toml | Updated evm_version to 'prague' to reflect the new EIP-2935 support. |
.changeset/wet-dodos-reply.md | Added changeset entry summarizing the Blockhash library feature. |
Files not reviewed (2)
- contracts/utils/Blockhash.sol: Language not supported
- test/utils/Blockhash.t.sol: Language not supported
Fixes #5639
PR Checklist
npx changeset add
)