Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 5.1 Full Audit Naming Suggestions #5215

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Implement 5.1 Full Audit Naming Suggestions #5215

merged 7 commits into from
Sep 25, 2024

Conversation

ernestognw
Copy link
Member

Fixes N-16

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2843690

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw ernestognw marked this pull request as ready for review September 19, 2024 00:16
Amxx
Amxx previously approved these changes Sep 20, 2024
View reviewed changes
@Amxx Amxx added this to the 5.1-after-freeze milestone Sep 20, 2024
cairoeth
cairoeth previously approved these changes Sep 20, 2024
View reviewed changes
@cairoeth cairoeth dismissed stale reviews from Amxx and themself via bebaa5d September 25, 2024 19:17
cairoeth
cairoeth previously approved these changes Sep 25, 2024
View reviewed changes
@ernestognw ernestognw merged commit 4c481d6 into OpenZeppelin:master Sep 25, 2024
21 checks passed
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Oct 1, 2024
@ernestognw @Amxx @cairoeth
Implement 5.1 Full Audit Naming Suggestions (OpenZeppelin#5215)
d240bde 
Co-authored-by: Hadrien Croubois <[email protected]>
Co-authored-by: cairo <[email protected]>
Signed-off-by: Hadrien Croubois <[email protected]>
Amxx added a commit that referenced this pull request Oct 2, 2024
@ernestognw @Amxx @cairoeth
Implement 5.1 Full Audit Naming Suggestions (#5215)
22ec876 
Co-authored-by: Hadrien Croubois <[email protected]>
Co-authored-by: cairo <[email protected]>
Signed-off-by: Hadrien Croubois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cairoeth cairoeth cairoeth approved these changes

@Amxx Amxx Amxx left review comments

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
5.1-after-freeze
Development

Successfully merging this pull request may close these issues.
3 participants
@ernestognw @Amxx @cairoeth