-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegate override vote #5192
Merged
Merged
Delegate override vote #5192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use public facing functions for override instead of params - rename some fields/variables - cleanup/implification
🦋 Changeset detectedLatest commit: ca6feb3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
arr00
reviewed
Oct 7, 2024
contracts/governance/extensions/GovernorOverrideDelegateVote.sol
Outdated
Show resolved
Hide resolved
Amxx
commented
Oct 16, 2024
Amxx
commented
Oct 16, 2024
Co-authored-by: Hadrien Croubois <[email protected]>
Co-authored-by: Hadrien Croubois <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #5160 (was not able to push commit to arr00's repository.
To discuss
VotesOverridable
: this is an extension ofVotes
that provides more features. It can be used to implement overrides, but it may also be used for other stuff. Maybe the name should not be so tightly associated with override.GovernorOverrideDelegateVote
: this is a counting module. IMO the name should reflect that.GovernorCountingOverridable
?GovernorAlreadyCastVoteOverride
: I think we can do better.overrideVote
,overrideVoteBySig
: should it include "cast"overrideVotes
is executed.VoteCast
event?_castVote
function. We need to ensure these two extensions are compatible. Some options:_castVote
from this function. This would necessitate the usage of vote params._update
function on the ERC20 token.PR Checklist
npx changeset add
)