Add Memory utility library
#5189
Conversation
🦋 Changeset detectedLatest commit: a7e61c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
||
| /// @dev Memory utility library. | ||
| library Memory { | ||
| type Pointer is bytes32; |
There was a problem hiding this comment.
Should we call that type type FMP is bytes32; ?
There was a problem hiding this comment.
I'd be better with FreePointer as FMP is not obvious at first.
EDIT: Acutally I do prefer just Pointer, since it's not always the free memory pointer. Anyone can get a point to wherever they want with asPointer
There was a problem hiding this comment.
would we rename the getFreePointer and setFreePointer to getFreeMemoryPointer and setFreeMemoryPointer ?
|
IMO this PR should include the usage of this lib |
| } | ||
| ---- | ||
|
|
||
| In this way, new memory will be allocated in the space where the `returndata` and `callData` used to be, potentially reducing memory expansion costs by shrinking the its size at the end of the transaction and resulting in gas savings. |
There was a problem hiding this comment.
| In this way, new memory will be allocated in the space where the `returndata` and `callData` used to be, potentially reducing memory expansion costs by shrinking the its size at the end of the transaction and resulting in gas savings. | |
| In this way, memory allocated to accomodate the `callData` and `returndata` is freed. This allows other memory operations to reuse that space, thus reducing the memory expansion costs of these operations. In particular, this allows performing many `callFoo` in a loop with limite memory expansion costs. |
Picked from #5094
PR Checklist
npx changeset add)