Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ERC4626Fees example to account for fees in maxWithdraw #5135

Closed
wants to merge 3 commits into from
Closed

Refactor ERC4626Fees example to account for fees in maxWithdraw #5135

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d1562d
Add note to ERC4626Fees
ernestognw Jul 29, 2024
09543b8
Refactor ERC4626Fees example to account for fees in `maxWithdraw`
ernestognw Jul 30, 2024
59b923f
Merge branch 'master' into erc4626fees/maxWithdraw
ernestognw Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions contracts/mocks/docs/ERC4626Fees.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ abstract contract ERC4626Fees is ERC4626 {

// === Overrides ===

/// @dev Maximum amount of the underlying asset that can be withdrawn from the owner's balance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// @dev Maximum amount of the underlying asset that can be withdrawn from the owner's balance.
/// @dev Maximum amount of the underlying asset that can be withdrawn from the owner's balance after subtracting fees.

function maxWithdraw(address owner) public view virtual override returns (uint256) {
return previewRedeem(maxRedeem(owner));
}

/// @dev Preview taking an entry fee on deposit. See {IERC4626-previewDeposit}.
function previewDeposit(uint256 assets) public view virtual override returns (uint256) {
uint256 fee = _feeOnTotal(assets, _entryFeeBasisPoints());
Expand Down
Loading