Reorganize changelog entries for 5.1 #5131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed in our call, we should consider whether we want to use this format in later releases. For now it's looking good but I need to take a look to the tests since the gas estimation is failing (not a big deal) |
ernestognw
reviewed
Sep 5, 2024
ernestognw
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
I went ahead and pushed the suggested changes, I think this way the diff reads way better and we keep consistent order.
Last time the gas comparison failed but I'm guessing is because there's no report to compare against. Should be fine since we're not changing code in this PR
ernestognw
changed the title
|
We'll wait before cherry-picking everything from #5139, otherwise the changelog will regenerate |
github-actions
bot
force-pushed
the
changeset-release/release-v5.1
branch
from
aba9ff6
to
878a26c
Compare
Amxx
force-pushed
the
changeset-release/release-v5.1-reorder
branch
from
1165d61
to
e740579
Compare
ernestognw
approved these changes
Oct 2, 2024
Amxx
merged commit 2369a64
into
OpenZeppelin:changeset-release/release-v5.1
13 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changelog entry that was automatically generated in #5124 is messy. This proposes to reorganise it following what we did for 5.0