Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency p-limit to v6 #5104

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Update dependency p-limit to v6 #5104

merged 5 commits into from
Oct 29, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 4, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
p-limit ^3.1.0 -> ^6.0.0 age adoption passing confidence

Release Notes

sindresorhus/p-limit (p-limit)

v6.1.0

Compare Source

v6.0.0

Compare Source

  • Improve performance (#​83) 80273d7
    • This is a major version because it slightly changes the timing of .activeCount and .pendingCount. This is unlikely to affect most users, but I wanted to play it safe. Learn more.

v5.0.0

Compare Source

Breaking

As a reminder, this package continues to require ESM. For TypeScript users, this includes having "module": "node16", "moduleResolution": "node16" in your tsconfig.

Fixes

v4.0.0

Compare Source

Breaking

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

changeset-bot bot commented Jul 4, 2024

⚠️ No Changeset found

Latest commit: f30191f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

socket-security bot commented Jul 4, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None +1 14.5 kB sindresorhus

View full report↗︎

@ernestognw
Copy link
Member

Related to #4716 (comment), we should explore how to update this dependency correctly.

@Toto0712 Toto0712 mentioned this pull request Jul 15, 2024
@cairoeth cairoeth mentioned this pull request Oct 19, 2024
1 task
Copy link
Contributor Author

renovate bot commented Oct 23, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

socket-security bot commented Oct 23, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
AI-detected potential code anomaly pypi/[email protected]
  • Notes: The code contains multiple potential security risks, including unauthorized file writes, command injection, information leakage, and code injection. It should be reviewed and modified to ensure proper input validation, sanitization, and secure handling of user input. The presence of 'eval' raises concerns about the safety and security of the code.
  • Confidence: 0.80
  • Severity: 0.70
🚫
AI-detected potential code anomaly pypi/[email protected]
  • Notes: The code contains multiple potential security risks, including unauthorized file writes, command injection, information leakage, and code injection. It should be reviewed and modified to ensure proper input validation, sanitization, and secure handling of user input. The presence of 'eval' raises concerns about the safety and security of the code.
  • Confidence: 0.80
  • Severity: 0.70
🚫
AI-detected potential code anomaly pypi/[email protected]
  • Notes: The code contains multiple potential security risks, including unauthorized file writes, command injection, information leakage, and code injection. It should be reviewed and modified to ensure proper input validation, sanitization, and secure handling of user input. The presence of 'eval' raises concerns about the safety and security of the code.
  • Confidence: 0.80
  • Severity: 0.70
🚫
AI-detected potential code anomaly pypi/[email protected]
  • Notes: The code contains multiple potential security risks, including unauthorized file writes, command injection, information leakage, and code injection. It should be reviewed and modified to ensure proper input validation, sanitization, and secure handling of user input. The presence of 'eval' raises concerns about the safety and security of the code.
  • Confidence: 0.80
  • Severity: 0.70
🚫

View full report↗︎

Next steps

What is an AI-detected potential code anomaly?

AI has identified unusual behaviors that may pose a security risk.

An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@Amxx
Copy link
Collaborator

Amxx commented Oct 23, 2024

Note: p-limit is used only in certora/run.js which we are going to remove as we stop using certora ?

@cairoeth
Copy link
Contributor

cairoeth commented Oct 23, 2024

Pushed commits to use imports in the certora run script so that it can use p-limit v6 -- imo we can merge this for now until it's clear we remove certora.

@cairoeth cairoeth requested a review from Amxx October 23, 2024 08:08
certora/run.js Outdated Show resolved Hide resolved
Co-authored-by: Hadrien Croubois <[email protected]>
@cairoeth cairoeth requested a review from Amxx October 23, 2024 13:11
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script is going to be removed soon anyway.

@cairoeth cairoeth merged commit 3da7a86 into master Oct 29, 2024
16 of 17 checks passed
@cairoeth cairoeth deleted the renovate/p-limit-6.x branch October 29, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants