Non-Fungible Votes - assign NFTs with different voting weight #3755
+642
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oting power - user _unitsBalance() to map current user power balance - delegates() default to current address, instead of zero address - _getVotingUnits() is no longer virtual and shouldn't be overridden
Function powerOfToken(tokenId) used to return token power for token Id
toledoroy
changed the title
|
Removed the forced opt-in to make things more compatible with the existing Votes extension. Everything's much simpler and more elegant now. Still wondering what to do about the behaviour tests. It passes only if the voting power for each token is worth 1 vote. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
As a follow-up on a forum thread regarding the assignment of different voting power for different ERC721 tokens.
https://forum.openzeppelin.com/t/erc721-voting-power-based-on-some-property/24550/22
Problems
Solution
Remove the opt-out option and track all voting power movements for all accounts at all time.
Drawbacks:
However, in some cases, post merge, and on L2s this increase in transaction fees might be worth it.
Description
This PR includes a new version of Votes, dubbed VotesForced, with a new integration for ERC721 that uses an arbitrary token power function to determine the voting power for each token.
PR Checklist