Skip to content

Conversation

@CeliktepeMurat
Copy link
Contributor

@CeliktepeMurat CeliktepeMurat changed the title Review switch#2 Review New Level:Switch#2 Jan 13, 2023
@xaler5
Copy link
Collaborator

xaler5 commented Jan 13, 2023

Hey @staa99

We moved your PR to this one because of rebasing and update to newer solidity version.

I wanted to propose you the following:

We already have a level named Switch, so this would more like a Switch 2. I loved your level so I thought you might be interested in adding it a little twist to make it harder.

What if the switches were two instead of one ? The first one being the one you already created, while the second one might be a recent vulnerability OZ had in the ECDSA library. Notice that the vulnerability is present at a specific version so the level should change to:

  • Use ECDSA OZ library instead of plain ecrecover
  • Use the specific version of ECDSA with the vulnerability

You can read about the vulnerability here
GHSA-4h98-2769-gh6h

And here
OpenZeppelin/openzeppelin-contracts@d693d89

Wdyt ?

@xaler5 xaler5 marked this pull request as ready for review April 3, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants