Fuzz tests for StorePacking #1296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-fleming
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Instead of having a separate file for these, what do you think about just moving the proposal core test into proposal_core/tests and then make a local tests mod in the multisig/storage_utils file?
ericnordelo
reviewed
Feb 27, 2025
| @@ -0,0 +1,38 @@ | |||
| use crate::governor::ProposalCore; | |||
There was a problem hiding this comment.
We already have this file now in main, so we need to merge these tests into that.
| proposer_val: felt252, | ||
| vote_start: u64, | ||
| vote_duration: u64, | ||
| executed_val: u8, |
There was a problem hiding this comment.
We can implement Fuzzable for bool as described here with 0.38.0. Let's use that for our fuzz tests types (applies for other PRs as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fuzz test cases for StorePacking logic of various structs:
TxInfoandProposalCorein governance package, andSecp256k1PointandSecp256r1Pointin account package.