Allow multivalue parameters to be deferred lazily #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, values returned from a deferred function would be wrapped inside an array when resolved lazily (with the default setting `preprocess_deferred=false`.) The resolution functions didn't detect this and the value was not resolved before the resource was enforced. That error case didn't occur when preprocessing, which just enumerated all values and resolved them before entering the resolution lifecycle. This change just avoids wrapping in an extra array. It expects the function itself to return an array and will fail with an appropriate error during catalog enforcement if it does not. Example: ``` Notice: Compiled catalog for waffles.localdomain in environment production in 0.01 seconds Error: Failed to apply catalog: value returned from function 'expand_groups' has wrong type, expects an Array value, got Integer ``` Fixes OpenVoxProject#213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, values returned from a deferred function would be
wrapped inside an array when resolved lazily (with the default setting
preprocess_deferred=false.) The resolution functions didn't detectthis and the value was not resolved before the resource was enforced.
That error case didn't occur when preprocessing, which just enumerated
all values and resolved them before entering the enforcement lifecycle.
This change just avoids wrapping in an extra array. It expects the
function itself to return an array and will fail with an appropriate
error during catalog enforcement if it does not.
Error example:
Fixes #213