-
Notifications
You must be signed in to change notification settings - Fork 58
Update _UIHostingView API #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Augment PR SummarySummary: This PR updates UIKit hosting integration to better track UIKit-driven state changes (traits, safe area, tint, clips) and to bridge UIKit animation blocks into OpenSwiftUI transactions. Changes:
Technical Notes: The new transaction bridging relies on private UIKit/QuartzCore SPI via “safe wrapper” indirection and compiles conditionally based on QuartzCore availability. 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| } | ||
| } | ||
|
|
||
| open override func tintColorDidChange() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UIView override hooks like tintColorDidChange() typically need to call super to preserve UIKit’s internal tint propagation/behavior; otherwise some subview updates can be skipped. This likely also applies to the new traitCollectionDidChange(_:) and safeAreaInsetsDidChange() overrides in this same block.
🤖 Was this useful? React with 👍 or 👎
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
===========================================
- Coverage 28.75% 14.29% -14.46%
===========================================
Files 589 563 -26
Lines 35836 33190 -2646
===========================================
- Hits 10305 4745 -5560
- Misses 25531 28445 +2914 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.