-
Notifications
You must be signed in to change notification settings - Fork 58
Add notify API and add test case for ViewGraphGeometryObservers #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Augment PR SummarySummary: Adds a direct notification API to emit geometry observer callbacks once measurements transition into a pending state. Changes:
Technical Notes: The test triggers a size change via 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| } | ||
|
|
||
| // [?] | ||
| mutating func notify() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If notify() is intended to be part of the same package-level API surface as needsUpdate(graph:) / notifySizes(), consider marking it package (it’s currently internal, so other modules in the package can’t call it). If it’s only meant for tests/internal use, this may be fine.
🤖 Was this useful? React with 👍 or 👎
| } | ||
| let emptyViewGraph = ViewGraph(rootViewType: EmptyView.self) | ||
| _ = observers.needsUpdate(graph: emptyViewGraph) | ||
| TestMeasurer.mockValue = 30.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
===========================================
- Coverage 28.80% 14.31% -14.50%
===========================================
Files 589 563 -26
Lines 35794 33167 -2627
===========================================
- Hits 10312 4748 -5564
- Misses 25482 28419 +2937 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7b8a7fa to
e4a295b
Compare
No description provided.