Skip to content

[Bug Fix] Fix UIHostingViewBase pendingPreferencesUpdate and weak self issue #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 1 commit into from
Dec 28, 2025
+10 −13
Merged

[Bug Fix] Fix UIHostingViewBase pendingPreferencesUpdate and weak self issue #686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions Sources/OpenSwiftUI/Integration/Hosting/UIKit/View/UIHostingViewBase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,29 +255,26 @@ package class UIHostingViewBase {
return
}
cancelAsyncRendering()
guard updatesAtFullFidelity else {
guard pendingPreferencesUpdate else {
if updatesAtFullFidelity {
view.setNeedsLayout()
CoreTesting.needsRender = true
} else {
guard !pendingPreferencesUpdate else {
return
}
pendingPreferencesUpdate = true
DispatchQueue.main.async { [self] in
guard uiView != nil else {
DispatchQueue.main.async { [weak self] in
guard let self else {
return
}
pendingPreferencesUpdate = false
guard let host else {
return
}
guard canAdvanceTimeAutomatically else {
guard let host, canAdvanceTimeAutomatically else {
return
}
let interval = renderInterval(timestamp: .systemUptime) / Double(UIAnimationDragCoefficient())
host.render(interval: interval, updateDisplayList: false, targetTimestamp: nil)
}
return
}
view.setNeedsLayout()
CoreTesting.needsRender = true
}

package func requestUpdate(after delay: Double) {
Expand Down Expand Up @@ -410,8 +407,8 @@ package class UIHostingViewBase {
}
updateTimer?.invalidate()
nextTimerTime = updateTime
updateTimer = withDelay(delay) { [self] in
guard uiView != nil else {
updateTimer = withDelay(delay) { [weak self] in
guard let self else {
return
}
updateTimer = nil
Expand Down
Loading