Update PlatformDrawable API #673
Conversation
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| case 2: options.rbColorMode = Int32(try decoder.intField(field)) | ||
| case 3: options.flags = Flags(rawValue: UInt32(try decoder.intField(field))) | ||
| case 4: options.maxDrawableCount = Int8(try decoder.intField(field)) |
There was a problem hiding this comment.
The Int32/UInt32/Int8(...) conversions in protobuf decoding will trap on out-of-range (or negative) values, so malformed/forward-version data could crash decoding. Consider validating/clamping before converting so decode failures are handled as errors instead of traps.
🤖 Was this useful? React with 👍 or 👎
|
|
||
| package var _renderer: DisplayList.GraphicsRenderer? | ||
|
|
||
| package init() { |
There was a problem hiding this comment.
PlatformDrawableContent.State is public but its initializers are package, and PlatformDrawableContent.draw(...) requires an inout State; SPI clients outside this package may have no way to create/retain a State. If draw is intended for external PlatformDrawable implementers, it likely needs a constructible state type.
🤖 Was this useful? React with 👍 or 👎
|
|
||
| @_spi(DisplayList_ViewSystem) | ||
| @available(OpenSwiftUI_v6_0, *) | ||
| public struct PlatformDrawableOptions: Equatable, Sendable { |
There was a problem hiding this comment.
PlatformDrawableOptions is public SPI and PlatformDrawable.options is get set, but there’s no public/SPI initializer (and base is internal), which can make it impossible for external adopters to initialize their stored options. If the intent is framework-owned mutation only, consider making that contract explicit.
🤖 Was this useful? React with 👍 or 👎
|
|
||
| class RBDisplayListInterpolator {} | ||
|
|
||
| public enum RBDisplayList {} |
There was a problem hiding this comment.
As a case-less enum, RBDisplayList is uninhabited, so any API that takes it can’t be called in shim builds. Is a constructible placeholder type intended here?
🤖 Was this useful? React with 👍 or 👎
Kyle-Ye
force-pushed
the
feature/render
branch
from
25d72f9 to
3cd6e73
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
==========================================
- Coverage 13.86% 13.82% -0.05%
==========================================
Files 558 559 +1
Lines 32492 32555 +63
==========================================
- Hits 4505 4500 -5
- Misses 27987 28055 +68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.