-
Notifications
You must be signed in to change notification settings - Fork 58
Add SensoryFeedback API support #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review completed. 4 suggestions posted. Overall the SensoryFeedback plumbing looks cohesive; the notes focus on a couple of UIKit edge cases and platform-behavior mismatches.
Comment augment review to trigger a new review at any time.
Sources/OpenSwiftUI/View/Control/SensoryFeedback/UIKit/UIKitFeedbackImplementation.swift
Show resolved
Hide resolved
Sources/OpenSwiftUI/View/Control/SensoryFeedback/UIKit/UIKitSensoryFeedbackCache.swift
Outdated
Show resolved
Hide resolved
Sources/OpenSwiftUI/View/Control/SensoryFeedback/UIKit/UIKitSensoryFeedbackCache.swift
Show resolved
Hide resolved
Sources/OpenSwiftUI/View/Control/SensoryFeedback/UIKit/UIKitSensoryFeedbackCache.swift
Show resolved
Hide resolved
889313b to
8d98525
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
===========================================
+ Coverage 13.88% 28.45% +14.56%
===========================================
Files 556 583 +27
Lines 32418 35121 +2703
===========================================
+ Hits 4502 9992 +5490
+ Misses 27916 25129 -2787 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.