Skip to content

Fix ObjectCache LRU implementation #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kyle-Ye merged 7 commits into from
Nov 22, 2025
Merged

Fix ObjectCache LRU implementation #631

Kyle-Ye merged 7 commits into from
Nov 22, 2025

Conversation

@pookjw
Copy link
Member

@pookjw pookjw commented Nov 10, 2025

No description provided.

Kyle-Ye
Kyle-Ye reviewed Nov 15, 2025
View reviewed changes
Copy link
Collaborator

@Kyle-Ye Kyle-Ye left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general.

But let's add a test case to verify the fix in case of future regression. The current test case does not seem to cover the fix.

@Kyle-Ye
Copy link
Collaborator

Kyle-Ye commented Nov 22, 2025

I added bucketFullEviction and bucketCollisionEviction test case to cover the fix.

@Kyle-Ye Kyle-Ye changed the title Fix ObjectCache Fix ObjectCache LRU implementation Nov 22, 2025
@Kyle-Ye Kyle-Ye merged commit 182cebe into OpenSwiftUIProject:main Nov 22, 2025
6 of 8 checks passed
@Kyle-Ye
Copy link
Collaborator

Kyle-Ye commented Nov 22, 2025

Thanks @pookjw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kyle-Ye Kyle-Ye Kyle-Ye left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pookjw @Kyle-Ye