Skip to content

Update AnyView #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 2 commits into from
Feb 18, 2025
Merged

Update AnyView #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61a1c07
Update AnyView
Kyle-Ye Feb 18, 2025
b3140a4
Fix DynamicContainer crash
Kyle-Ye Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Sources/OpenSwiftUICore/Data/Environment/EnvironmentalView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@ struct EnvironmentalViewChild<V>: StatefulRule, AsyncAttribute, CustomStringConv
} else if envChanged, tracker.hasDifferentUsedValues(env.plist) {
shouldReset = true
} else {
// TODO: Optimize this API call
let outputValue: UnsafePointer<V.EnvironmentBody>? = Graph.outputValue()
shouldReset = outputValue == nil
shouldReset = !hasValue
}
guard shouldReset else { return }
tracker.reset()
Expand Down
7 changes: 5 additions & 2 deletions Sources/OpenSwiftUICore/Render/DisplayList/DisplayList_StableIdentity.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,12 @@ extension _GraphInputs {
}

package mutating func pushStableType(_ type: any Any.Type) {
#if OPENSWIFTUI_SUPPORT_2024_API
guard options.contains(.needsStableDisplayListIDs) else {
return
}
pushScope(id: makeStableTypeData(type))
#endif
}

package var stableIDScope: WeakAttribute<DisplayList.StableIdentityScope>? {
Expand All @@ -143,10 +145,11 @@ extension _GraphInputs {
}
}

#if OPENSWIFTUI_SUPPORT_2024_API
package func makeStableTypeData(_ type: any Any.Type) -> StrongHash {
// OGTypeGetSignature
preconditionFailure("TODO")
unsafeBitCast(Metadata(type).signature, to: StrongHash.self)
}
#endif

package func makeStableIDData<ID>(from id: ID) -> StrongHash? {
guard let encodable = id as? Encodable else {
Expand Down
Loading
Loading